[PATCH] D87927: [AIX][clang][driver] Make sure ctri.o is linked in C++ mode

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/test/Driver/aix-ld.c:16
 // CHECK-LD32:     "-bpT:0x10000000" "-bpD:0x20000000"
 // CHECK-LD32:     "[[SYSROOT]]/usr/lib{{/|\\\\}}crt0.o"
 // CHECK-LD32:     "-L[[SYSROOT]]/usr/lib"
----------------
There should be checks for not having `crti*.o` on the C invocations (at least insofar as we decided that we were going to have checks for not having `-lc++`).


================
Comment at: clang/test/Driver/aix-ld.c:321
 // CHECK-LD32-NOSTDLIBXX-LCXX:     "[[SYSROOT]]/usr/lib{{/|\\\\}}crt0.o"
+// CHECK-LD32-NOSTDLIBXX-LCXX:     "[[SYSROOT]]/usr/lib{{/|\\\\}}crti.o"
 // CHECK-LD32-NOSTDLIBXX-LCXX:     "-L[[SYSROOT]]/usr/lib"
----------------
I think this is right but is worth noting. The dynamic initialization/finalization functionality is of a more fundamental nature.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87927/new/

https://reviews.llvm.org/D87927