[PATCH] D75791: [clang-format] Added new option IndentExternBlock

Mon Sep 21 13:43:22 PDT 2020

MarcusJohnson91 added a comment.

@sylvestre.ledru

After looking more closely at the issue, it seems you're having an issue with Mozilla's comment alignment option.

you want the comments to be aligned, and it appears Clang11 no longer has that option set for Mozilla's style is what you're saying?

How are you accessing Mozilla's style?

are you calling clang-format with `-style=mozilla`, or `-style=file` and you've got an implicit .clang-format somewhere?

----

No matter what the root cause, I still think it's a good idea to directly use the variables instead of messing around with an unwieldy bool table.

the bool table is just asking for trouble anytime BraceWrapping is expanded, or even reordered, so I'm glad that I just pushed that new patch here and hopefully it'll land soon.

----

as for completely cutting out the old AfterExternBlock option, I'd like to fully supersede it still, I just need a good name for wrapping the extern blocks opening curly brace, anybody got any ideas?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791