[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

Mon Sep 21 13:21:46 PDT 2020

fhahn added a comment.

In D87972#2284060 <https://reviews.llvm.org/D87972#2284060>, @MaskRay wrote:

> I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

That's a bit of a surprise to me! It would be great to know how/why running SROA later makes things worse in some cases.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87972/new/

https://reviews.llvm.org/D87972