[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Mon Sep 21 12:23:59 PDT 2020

tra accepted this revision.
tra added a comment.

In D84362#2283078 <https://reviews.llvm.org/D84362#2283078>, @tra wrote:

> It's possible. Unfortunately it's only triggered by our internal tool and it's hard to create a public reproducer for it. I'll debug and try to fix it on Monday.

It appears the patch slightly increased stack use and caused a failure in code that was running with a limited stack space available.
AFAICT there are no issues with this patch per se and it's good to re-land, again.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362