[PATCH] D87350: [AST][RecoveryExpr] Fix a crash on undeduced type.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:12880
 
   return Result.getValueOr(QualType());
 }
----------------
sammccall wrote:
> Wouldn't we be better to handle undeduced type here rather than in the loop?
> 
> Not sure if it practically matters, but given: `auto f(); double f(int); f(0,0);`
> the code in this patch will discard auto and yield `double`, while treating this as multiple candidates --> unknown return type seems more correct.
> 
I feel like yield `double` is better in your given example -- in this case, double is the only candidate, so it is reasonable to preserve the `double` type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87350/new/

https://reviews.llvm.org/D87350