[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 20 23:39:41 PDT 2020


baloghadamsoftware added a comment.

In D81272#2276342 <https://reviews.llvm.org/D81272#2276342>, @sylvestre.ledru wrote:

> Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code (fixed with the autofix):
> https://hg.mozilla.org/mozilla-central/rev/651e68f628d0
>
> https://bugzilla.mozilla.org/show_bug.cgi?id=1664747
> (unlikely that it was causing any actual bugs in the product)

Thank you for your info. These defects do not cause any bug directly, but they make code understanding harder which may cause bugs in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81272/new/

https://reviews.llvm.org/D81272



More information about the cfe-commits mailing list