[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 20 10:54:32 PDT 2020


lebedev.ri added a comment.

In D87972#2284064 <https://reviews.llvm.org/D87972#2284064>, @xbolva00 wrote:

> In D87972#2284060 <https://reviews.llvm.org/D87972#2284060>, @MaskRay wrote:
>
>> I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.
>
> Snappy  - you mean public https://github.com/google/snappy?
>
> Well, it should be possible to analyze it...



> @lebedev.ri any perf data from testsuite/rawspeed?

I did look. F13016699: sroa-after-unroll.rsbench.txt <https://reviews.llvm.org/F13016699>
This suggests that geomean is `-0.8%` runtime improvement,
with ups&downs. F13016722: image.png <https://reviews.llvm.org/F13016722>

But as i have said in the patch's description, i stumbled into this when writing new code, where the effect is //much// larger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87972/new/

https://reviews.llvm.org/D87972



More information about the cfe-commits mailing list