[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

Sun Sep 20 09:51:42 PDT 2020

xbolva00 added a comment.

In D87972#2284060 <https://reviews.llvm.org/D87972#2284060>, @MaskRay wrote:

> I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Should be same story for NPM since NPM also enables SROA after unrolling.

A) Commit this patch and start working on general solution for LPM and NPM.

B) Ignore this patch. But after LLVM switches to NPM, you have same issue to solve anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87972/new/

https://reviews.llvm.org/D87972