[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

Fri Sep 18 22:34:23 PDT 2020

craig.topper added a comment.

In D87888#2281360 <https://reviews.llvm.org/D87888#2281360>, @RKSimon wrote:

> Do we have sufficient backend test coverage for this?

Taking a closer look, I don't think our coverage is very good. We just have one test for each the 28 condition code strings we support and they are all identical tests that just change the string. So we don't have tests that use the condition code as a branch condition. But the code just emits a EFLAGS copy and X86ISD::SETCC so existing combines probably just work.

I did fine a copy paste mistake on one of the condition strings while reviewing the asm flags code. Fixed in 58ecbbcdcddf80b289c449b86d5996d58fba0d78 <https://reviews.llvm.org/rG58ecbbcdcddf80b289c449b86d5996d58fba0d78>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87888/new/

https://reviews.llvm.org/D87888