[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Fri Sep 18 14:55:31 PDT 2020

yaxunl added a comment.

In D84362#2283045 <https://reviews.llvm.org/D84362#2283045>, @tra wrote:

> In D84362#2282992 <https://reviews.llvm.org/D84362#2282992>, @yaxunl wrote:
>
>> The fix is for the change in D84364 <https://reviews.llvm.org/D84364>. It has no effect on the change in this review. Are you sure the issue you saw is due to change in this review instead of change in D84364 <https://reviews.llvm.org/D84364>?
>
> Pretty sure. We've bisected the failure specifically to commit ee5519d323571c4a9a7d92cb817023c9b95334cd <https://reviews.llvm.org/rGee5519d323571c4a9a7d92cb817023c9b95334cd>, before  D84364 <https://reviews.llvm.org/D84364> landed.

I think this is probably a different issue. The issue reported in D84364 <https://reviews.llvm.org/D84364> was introduced by change in D84364 <https://reviews.llvm.org/D84364>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362