[PATCH] D87779: [SyntaxTree] Test `findFirstLeaf` and `findLastLeaf`

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:9
+//
+// This file tests the Syntax Tree base API.
+//
----------------
Please elaborate what "base API" covers -- specifically, what classes and such.  However, I'm not sure it is necessary to have this comment at all. Up to you.


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:39
+    return ::testing::AssertionSuccess();
+  }
+
----------------
Is this copied from somewhere? I feel like other tests have this function already. Can we share?


================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:52
+
+  // Generate Forests by combining `Children` under `ParentCount` Trees.
+  //
----------------
under => into?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87779/new/

https://reviews.llvm.org/D87779