[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

Fri Sep 18 14:02:26 PDT 2020

yaxunl added a comment.

In D84362#2279845 <https://reviews.llvm.org/D84362#2279845>, @tra wrote:

> In D84362#2279688 <https://reviews.llvm.org/D84362#2279688>, @tra wrote:
>
>> Apparently this patch triggers compiler crashes on some of our code. I'll try to create a reproducer, but it would be great to revert the patch for now.
>
> It's likely the same issue as the one reported in D84364 <https://reviews.llvm.org/D84364>, but we probably triggered it independently.

I have a fix for the issue reported in D84364 <https://reviews.llvm.org/D84364>. Would you like to try? Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84362/new/

https://reviews.llvm.org/D84362