[PATCH] D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility

[Raul Tambre via Phabricator via cfe-commits]

tambre added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:9674
             ASTContext::GetBuiltinTypeError Error;
+            LookupPredefedObjCSuperType(*this, S, NewFD->getIdentifier());
             QualType BuiltinType = Context.GetBuiltinType(BuiltinID, Error);
----------------
rjmccall wrote:
> Can we avoid doing this except for the small number of builtins that use `struct objc_super`?  We already have the BuiltinID.
`LookupPredefedObjCSuperType()` already checks if the identifier is `"objc_msgSendSuper"`. But it'd probably be more efficient to check the `BuiltinID`. I'll follow this up tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87917/new/

https://reviews.llvm.org/D87917