[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, though you may want to get a second set of eyes on the swift name validation bits for a more thorough review of that part.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3997
+def warn_attr_swift_name_setter_parameters
+  : Warning<"%0 attribute for setter must take one parameter for new value">,
+    InGroup<SwiftNameAttribute>;
----------------
compnerd wrote:
> aaron.ballman wrote:
> > take -> have
> > 
> > elsewhere `new value` is spelled `'newValue:`, should that be the same here?
> `newValue:` is the argument label spelling and "new value" is the argument value, which is the reason for the difference.
That makes sense to me, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87534/new/

https://reviews.llvm.org/D87534