[PATCH] D85810: [clang] Pass-through remarks options to linker

[Wei Wang via Phabricator via cfe-commits]

weiwang marked an inline comment as done.
weiwang added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90
+  } else {
+    if (Output.isFilename())
+      F = Output.getFilename();
----------------
MaskRay wrote:
> The output selection logic is untested.
I am not sure how to trigger a case of `Output` not being a filename in test case. 


================
Comment at: clang/test/Driver/opt-record.c:24
+// No pass-through: lto is disabled
+// RUN: %clang -target x86_64-linux-gnu -### -o FOO -fdiagnostics-hotness-threshold=100 -fsave-optimization-record %s 2>&1 | not FileCheck %s -check-prefix=CHECK-PASS
+
----------------
MaskRay wrote:
> x86_64-linux-gnu can usually be simplied as x86_64.
> 
> There is no test without `-o FOO`.
> 
> Consider moving the RUN lines below, immediately above CHECK-PASS: lines
`x86_64` somehow gives error for the toolchain to generate linker command. I've updated the triple to be `x86_64-linux`.

Without `-o FOO`, it would just use the default output name `a.out`.

As suggested, changed lines are moved together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85810/new/

https://reviews.llvm.org/D85810