[PATCH] D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body.

Sukraat Ahluwalia via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 17 17:13:27 PDT 2020


sukraat91 updated this revision to Diff 292669.
sukraat91 added a comment.

Address comments to remove top level `const auto` in the helper function to check if the argument is being moved, and replace it with its type spelled out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87540/new/

https://reviews.llvm.org/D87540

Files:
  clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87540.292669.patch
Type: text/x-patch
Size: 4147 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200918/51f257b0/attachment.bin>


More information about the cfe-commits mailing list