[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added a comment.

In D87791#2279885 <https://reviews.llvm.org/D87791#2279885>, @tra wrote:

> In D87791#2279864 <https://reviews.llvm.org/D87791#2279864>, @yaxunl wrote:
>
>> It is requested by our debugger team, so it should work with amdgpu.
>
> Is the naming scheme for GPU-side DWO files dictated by debugger? If that's the case, it may be worth adding a comment about that.
>
> LGTM.

It is the preferred naming by the debugger. Will add a comment.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:918
   if (FinalOutput && Args.hasArg(options::OPT_c)) {
-    SmallString<128> T(FinalOutput->getValue());
+    SmallString<128> T(llvm::sys::path::stem(FinalOutput->getValue()));
+    AddPostfix(T);
----------------
MaskRay wrote:
> Does `stem` change the semantics?
No. replace_extension will take stem first and then add new extension.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87791/new/

https://reviews.llvm.org/D87791