[PATCH] D79916: Map -O to -O1 instead of -O2

Thu Sep 17 11:38:52 PDT 2020

Bdragon28 added a comment.

In D79916#2279918 <https://reviews.llvm.org/D79916#2279918>, @jrtc27 wrote:

> In D79916#2279901 <https://reviews.llvm.org/D79916#2279901>, @Bdragon28 wrote:
>
>> In D79916#2279884 <https://reviews.llvm.org/D79916#2279884>, @jrtc27 wrote:
>>
>>> But also you really should not get warnings for unused static functions in included headers, only ones defined in the C source file itself. We'd have countless warnings in the kernel across all architectures otherwise.
>>
>> I agree. But that's what it is doing when using always_inline in combination with -Wunused-function.
>>
>> There is currently no real usage of always_inline in system headers though, so maybe I'm just the first to complain about it?
>
> We use them in CheriBSD and have no such issues that I've ever noticed. When was the last time you checked (and what compiler)?

Five minutes ago, FreeBSD clang version 11.0.0 (git at github.com:llvm/llvm-project.git llvmorg-11.0.0-rc2-0-g414f32a9e86)

Using __always_inline __unused appears to work to silence the warnings, however, so that is probably workable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79916/new/

https://reviews.llvm.org/D79916