[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

Thu Sep 17 11:12:13 PDT 2020

yaxunl marked an inline comment as done.
yaxunl added a comment.

In D87791#2279821 <https://reviews.llvm.org/D87791#2279821>, @tra wrote:

> In D87791#2278417 <https://reviews.llvm.org/D87791#2278417>, @yaxunl wrote:
>
>> Therefore in either case there is no need to rename the intermediate .o files since they are temporary files which have unique names.
>>
>> The .dwo files are not temporary files. They are supposed to be shipped with .o files for debugging info.
>
> Ack.  
> BTW, is split-dwarf useful for AMD GPUs on device side? I don't think we can currently utilize DWO files on device side with CUDA at all. To think of it, it's probably going to break GPU-side debugging as CUDA can only deal with dwarf info embedded in the GPU binary. 
> If it does not work for AMD GPUs, perhaps we should just disable it for GPUs.

It is requested by our debugger team, so it should work with amdgpu.

>> Since .dwo files are not temporary files, it is not necessary to follow the -save-temps name convention. For the host object, we keep the original .dwo file name. For the device object, we add '_' and GPU arch to the stem, which is sufficient and concise.
>
> What will happen with `-save-temps` ? Will dwo files match object file names?

with -save-temps, the saved temporary files will be like test-hip-amdgcn-amd-amdhsa-gfx906.o. The dwo file will be like test_gfx906.dwo.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87791/new/

https://reviews.llvm.org/D87791