[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

Thu Sep 17 01:51:01 PDT 2020

arichardson added inline comments.

================
Comment at: llvm/utils/update_cc_test_checks.py:331
+            # are ordered by prefix instead of by function as in "normal"
+            # mode.
+            if '-emit-llvm' in clang_args:
----------------
jdoerfert wrote:
> This is all unfortunate but at least for OpenMP not easily changeable. Let's go with this.
How difficult would it be to only use this behaviour if the normal one fails? 

If we encounter a function that's not in the source code we just append the check lines for the generate function where we last added checks. And if we then see a function where the order doesn't match the source order fall back to just emitting all checks at the end of the file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83004/new/

https://reviews.llvm.org/D83004