[PATCH] D87791: [CUDA][HIP] Fix -gsplit-dwarf option

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 16 14:23:19 PDT 2020


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Does this naming scheme the same as used for `.o` files? We may want to keep them in sync.

Other than that, LGTM.



================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:909
+  auto AddPostfix = [JA](auto &F) {
+    if (JA.getOffloadingDeviceKind() == Action::OFK_HIP)
+      F += (Twine("_") + JA.getOffloadingArch()).str();
----------------
I think the same approach would make sense for CUDA, too. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87791/new/

https://reviews.llvm.org/D87791



More information about the cfe-commits mailing list