[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

Wed Sep 16 04:02:40 PDT 2020

ro added a comment.

In D87615#2275045 <https://reviews.llvm.org/D87615#2275045>, @efriedma wrote:

> Also, it would be nice to have some regression test coverage; add a Solaris RUN line to llvm/test/CodeGen/X86/stack-align2.ll ?

Sure, done in the updated patch.  I'd checked that if `FAIL`s with `llc -mtriple=i386-pc-solaris2.11 --stack-alignment=16`

================
Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:270
+  else if (isTargetSolaris() && !In64BitMode)
+    stackAlignment = Align(4);

----------------
efriedma wrote:
> stackAlignment is initialized to 4 in the header, so `stackAlignment = Align(4)` here is a no-op.
Ah, I missed that.  Fixed in the updated patch.  Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87615/new/

https://reviews.llvm.org/D87615