[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 16 00:33:34 PDT 2020
sammccall accepted this revision.
sammccall added a comment.
Thanks, this seems better than crashing.
The practical result isn't wonderful: the two are going to fight over index files to some extent. But this can happen with different clangd versions (that use different index format versions) anyway. So this is really just graceful recovery from a bad situation.
In D87673#2273347 <https://reviews.llvm.org/D87673#2273347>, @ArcsinX wrote:
> Unsure about test for this
Agree, testing this seems hard and not that useful.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87673/new/
https://reviews.llvm.org/D87673
More information about the cfe-commits
mailing list