[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

[Russell Yanofsky via Phabricator via cfe-commits]

ryanofsky added a comment.

Great feedback! I need to absorb it all then I'll fix the changeset. The mistakes about exceptions came from me taking "(no return)" in the previous documentation too literally thinking it was referring to https://en.cppreference.com/w/cpp/language/attributes/noreturn.

Re: "I got the impression that you want both runtime checks and compile-time checks in parallel". Personally I only want the compile checks, and would like to drop all the runtime checks except in handful of places where compile time checks don't work. ASSERT_CAPABILITY does a great job in these places so I don't want people to be scared off from using it unduly because of documentation!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87629/new/

https://reviews.llvm.org/D87629