[PATCH] D85685: Support dwarf fission for wasm object files
Sam Clegg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 15 18:16:05 PDT 2020
sbc100 added a comment.
Seems reasonable. Do you think this way is cleaner than the way elf does it? Looks like ELF creates two different ELFWriter inside the ELFDwoObjectWriter subclass right?
Are we going need to wasm-ld tests to followup or is this really independent of the linker?
================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:224
class WasmObjectWriter : public MCObjectWriter {
- support::endian::Writer W;
+ support::endian::Writer *W;
----------------
Kind of a same this change means changing so many line in this file ..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85685/new/
https://reviews.llvm.org/D85685
More information about the cfe-commits
mailing list