[PATCH] D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 15 07:32:37 PDT 2020


martong added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:352
   HelpText<"Improve modeling of the C standard library functions">,
-  Dependencies<[CallAndMessageModeling]>,
   CheckerOptions<[
----------------
Umm, we should not have removed this. The checker always asserts that the arguments are initialized and that is checked by the dependency.

This is causing an assertion in D87081. Unfortunately, we hadn't have any tests to catch this, but now we have one, exactly in D87081. So I am putting back this dependency there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87240/new/

https://reviews.llvm.org/D87240



More information about the cfe-commits mailing list