[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with some test location nits.



================
Comment at: clang/test/SemaObjC/attr-swift_bridged_typedef.m:2
+// RUN: %clang_cc1 -verify -fsyntax-only %s
+// RUN: not %clang_cc1 -fsyntax-only -ast-dump %s | FileCheck %s
+
----------------
Can you split this bit off into a separate test in the AST directory? Then you don't have to contend with the errors in the test file and it's a more realistic test (AST tests with errors present always leave me wondering how the AST will change as we add error recovery functionality to the AST).


================
Comment at: clang/test/SemaObjC/attr-swift_bridged_typedef.mm:1
+// RUN: %clang_cc1 -fsyntax-only %s -ast-dump | FileCheck %s
+
----------------
Can you move this test to the AST directory as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87396/new/

https://reviews.llvm.org/D87396