[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:2000
+defm split_machine_functions: OptInFFlag<"split-machine-functions",
+  "Enable", "Disable", " late function splitting using profile information (x86-elf only)">;
+
----------------
If this can be adapted to other targets, there is no need to specifically mention x86-elf only ("x86 ELF")


================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:12
 #include "clang/Basic/Diagnostic.h"
+#include "clang/Basic/DiagnosticFrontend.h"
 #include "clang/Basic/LangOptions.h"
----------------
This is not needed


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:27
 #include "clang/Basic/CodeGenOptions.h"
+#include "clang/Basic/DiagnosticFrontend.h"
 #include "clang/Basic/LangOptions.h"
----------------
Not needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87047/new/

https://reviews.llvm.org/D87047