[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 14 01:15:30 PDT 2020


alexfh accepted this revision.
alexfh added a comment.

Looks good modulo comment.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry-custom-macro.c:25
+void with_custom_macro() {
+  MY_TEMP_FAILURE_RETRY((foo()));
+  MY_TEMP_FAILURE_RETRY((int)(foo() == 1));
----------------
Are the extra parentheses required for the macro to work? Can it be just `MY_TEMP_FAILURE_RETRY(foo());` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83144/new/

https://reviews.llvm.org/D83144



More information about the cfe-commits mailing list