[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

Sat Sep 12 03:57:49 PDT 2020

mstorsjo added a comment.

In D87539#2269385 <https://reviews.llvm.org/D87539#2269385>, @mati865 wrote:

> We had this patch at MSYS2 for years and I'm not aware of any issues with the static library.
> I think the library looks fine:
>
>   $ nm lib/liblibclang.a | grep __imp_
>                    U __imp___acrt_iob_func
>                    U __imp___acrt_iob_func
>                    U __imp_GetModuleFileNameA
>                    U __imp_VirtualQuery
>                    U __imp___acrt_iob_func
>                    U __imp___acrt_iob_func
>                    U __imp___acrt_iob_func

What about `llvm-readobj --coff-directives | grep -i export:`? The effect is often very subtle - if you build another DLL, that has no explicit dllexports of its own but rely on the default of exporting all symbols - it fails if a statically linked dependency contains explicit dllexports and only exports the dependency's symbols.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87539/new/

https://reviews.llvm.org/D87539