[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In D87470#2268267 <https://reviews.llvm.org/D87470#2268267>, @lxfind wrote:

> hmm @rjmccall, I don't think there is a stable way to test this. The code generated for symmetric transfer is way too complicated to stably pattern match one less item in the frame.

I don't know that much about the code-generation here, but when cleanups escape into a surrounding scope, you can usually test that the cleanup is emitted before some call tied to a later statement in that scope.  You don't have to test for every last instruction in the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87470/new/

https://reviews.llvm.org/D87470