[PATCH] D87495: [SyntaxTree][Synthesis] Add support for simple Leafs and test based on tree dump
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 11 10:46:30 PDT 2020
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Tooling/Syntax/Synthesis.cpp:38
+ StringRef Spelling) {
+ auto *Leaf = createLeafLowLevel(A, Spelling);
+ assert(Leaf->getToken()->kind() == K &&
----------------
`createLeafLowLevel` now seems to be used only once, inline it?
================
Comment at: clang/unittests/Tooling/Syntax/SynthesisTest.cpp:46
+
+ auto *C = createLeaf(*Arena, tok::comma);
+
----------------
What does 'C' stand for?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87495/new/
https://reviews.llvm.org/D87495
More information about the cfe-commits
mailing list