r364428 - Make CodeGen depend on ASTMatchers

[Michael LIAO via cfe-commits]

b22d4504968 was committed last night.

On Fri, Sep 11, 2020 at 9:30 AM Vassil Vassilev <v.g.vassilev at gmail.com> wrote:
>
> On 9/11/20 5:13 AM, Michael LIAO wrote:
> > That change was added long ago to fix the shared library build.
> > Possibly, there are changes removing that dependency then. Just
> > verified that removing that dependency is just fine.
>
>
>    That's great! Would you commit that change or should I?
>
>
> >
> > On Thu, Sep 10, 2020 at 6:48 AM Vassil Vassilev <v.g.vassilev at gmail.com> wrote:
> >> Hello,
> >>
> >>     IIUC, clang's CodeGen does not immediately depend on ASTMatchers. I
> >> was wondering what is the reason for inserting such a dependency to fix
> >> the shared library builds?
> >>
> >>     Can you give more details about the failure you are fixing?
> >>
> >>     Sorry for the late question.
> >>
> >> Best, Vassil
> >> On 6/26/19 5:13 PM, Michael Liao via cfe-commits wrote:
> >>> Author: hliao
> >>> Date: Wed Jun 26 07:13:43 2019
> >>> New Revision: 364428
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=364428&view=rev
> >>> Log:
> >>> Make CodeGen depend on ASTMatchers
> >>>
> >>> - Shared library builds are broken due to the missing dependency.
> >>>
> >>> Modified:
> >>>       cfe/trunk/lib/CodeGen/CMakeLists.txt
> >>>
> >>> Modified: cfe/trunk/lib/CodeGen/CMakeLists.txt
> >>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CMakeLists.txt?rev=364428&r1=364427&r2=364428&view=diff
> >>> ==============================================================================
> >>> --- cfe/trunk/lib/CodeGen/CMakeLists.txt (original)
> >>> +++ cfe/trunk/lib/CodeGen/CMakeLists.txt Wed Jun 26 07:13:43 2019
> >>> @@ -101,6 +101,7 @@ add_clang_library(clangCodeGen
> >>>      LINK_LIBS
> >>>      clangAnalysis
> >>>      clangAST
> >>> +  clangASTMatchers
> >>>      clangBasic
> >>>      clangFrontend
> >>>      clangLex
> >>>
> >>>
> >>> _______________________________________________
> >>> cfe-commits mailing list
> >>> cfe-commits at lists.llvm.org
> >>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> >>
>