[PATCH] D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus updated this revision to Diff 291199.
Szelethus marked 4 inline comments as done.
Szelethus added a comment.

Reinstate the assert removed in rG032b78a0762bee129f33e4255ada6d374aa70c71 <https://reviews.llvm.org/rG032b78a0762bee129f33e4255ada6d374aa70c71>, add a test. Enforce that `Environment` only makes an exception for `ReturnStmt` in terms of non-expression statements (and hope that isn't going to stay that way for long).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86736/new/

https://reviews.llvm.org/D86736

Files:
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h
  clang/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp
  clang/lib/StaticAnalyzer/Checkers/UndefBranchChecker.cpp
  clang/lib/StaticAnalyzer/Core/Environment.cpp
  clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
  clang/lib/StaticAnalyzer/Core/ExprEngineObjC.cpp
  clang/lib/StaticAnalyzer/Core/SymbolManager.cpp
  clang/test/Analysis/objc-live-crash.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86736.291199.patch
Type: text/x-patch
Size: 14292 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200911/adc6fca9/attachment-0001.bin>