[PATCH] D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 10 22:12:30 PDT 2020
rjmccall added a comment.
Follow-up on my previous request. It's fine by me if you commit with that fix.
================
Comment at: clang/lib/Analysis/BodyFarm.cpp:188
+ const_cast<Expr *>(Arg), nullptr, VK_RValue,
+ FPOptionsOverride());
}
----------------
rjmccall wrote:
> Can these call sites just be changed to use `makeImplicitCast`?
Can you do the one in makeIntegralCast, too? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85960/new/
https://reviews.llvm.org/D85960
More information about the cfe-commits
mailing list