[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/include/clang/Driver/Options.td:1992
 
+def fsplit_machine_functions : Flag <["-"], "fsplit-machine-functions">,
+  Group<f_Group>, Flags<[CC1Option]>,
----------------
Please use `OptInFFlag` and see its comment.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4259
         options::OPT_fno_unique_basic_block_section_names,
+        options::OPT_fsplit_machine_functions,
+        options::OPT_fno_split_machine_functions,
----------------
This is not needed.

This is for fembed-bitcode and people seem to randomly add options here. Many options are probably not needed.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4922
+      D.Diag(diag::err_drv_unsupported_opt_for_target)
+          << "-fsplit-machine-functions" << TripleStr;
+  }
----------------
If you use getLastArg

A->getAsString(Args)


================
Comment at: clang/test/CodeGen/split-machine-functions.c:3
+
+// RUN: echo "foo"                > %t.proftext
+// RUN: echo "# Func Hash:"       >> %t.proftext
----------------
Consider `RUN: split-file`

Search for this string for some examples.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87047/new/

https://reviews.llvm.org/D87047