[PATCH] D83144: Allow to specify macro names for android-comparison-in-temp-failure-retry.

[Stephen Hines via Phabricator via cfe-commits]

srhines added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry.c:1
-// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t
+// RUN: %check_clang_tidy %s android-comparison-in-temp-failure-retry %t -- -config="{CheckOptions: [{key: android-comparison-in-temp-failure-retry.RetryMacros, value: 'TEMP_FAILURE_RETRY,MY_TEMP_FAILURE_RETRY'}]}"
 
----------------
Ideally there should either be another RUN macro here without your new options, or there should be a separate test/file for checking here, since we'd like to make sure that the default behavior still works.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/android-comparison-in-temp-failure-retry.c:28
   TEMP_FAILURE_RETRY(foo());
   TEMP_FAILURE_RETRY((foo()));
 
----------------
Don't you want a check for `MY_TEMP_FAILURE_RETRY` for cases like this too (to make sure that it is detecting them)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83144/new/

https://reviews.llvm.org/D83144