[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 10 12:56:20 PDT 2020


gribozavr2 added inline comments.


================
Comment at: clang/test/SemaObjC/attr-swift_objc_members.m:4
+#if !__has_attribute(swift_objc_members)
+#error cannot verify precense of swift_objc_members attribute
+#endif
----------------
aaron.ballman wrote:
> gribozavr2 wrote:
> > 
> The typo fix makes sense to me, but for my own understanding, why switch to a string literal?
IIUC, as it is now, the message is tokenized by the lexer -- and I think that's not the intent, none of these words are program code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87395/new/

https://reviews.llvm.org/D87395



More information about the cfe-commits mailing list