[PATCH] D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 10 06:34:54 PDT 2020
lebedev.ri reopened this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
So i've just reverted this.
@aaron.ballman @baloghadamsoftware how's QC going on nowadays here?
Was this evaluated on anything other than it's tests?
It appears to be either unacceptably slow, or subtly broken, because it takes at least 100x time more than all of the other clang-tidy checks enabled, and e.g.
`clang-tidy-12 --checks="-*,cppcoreguidelines-prefer-member-initializer" -p . /repositories/llvm-project/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp`
never finishes (minutes and counting).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71199/new/
https://reviews.llvm.org/D71199
More information about the cfe-commits
mailing list