[PATCH] D87187: [Driver] Perform Linux distribution detection just once
Sylvestre Ledru via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 9 23:30:49 PDT 2020
sylvestre.ledru added a comment.
I guess it isn't possible to write tests for this?
Does it have an impact on cross compile ?
Also, please fix the clang-format warning!
================
Comment at: clang/lib/Driver/Distro.cpp:227
+ if (!HostTriple.isOSLinux() && onRealFS)
+ Type = Distro::UnknownDistro;
+ else
----------------
you could probably do "return Distro::Un" here
(same line 230)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87187/new/
https://reviews.llvm.org/D87187
More information about the cfe-commits
mailing list