[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

Rahman Lavaee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 9 18:24:00 PDT 2020


rahmanl accepted this revision.
rahmanl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/Driver/fbasic-block-sections.c:11
 // CHECK-OPT-LABELS: "-fbasic-block-sections=labels"
+// CHECK-NOOPT-NOT:  "-fbasic-block-sections"
----------------
nit, ignore if you want:
CHECK-NOOPT-NOT sounds like double negative? How about using CHECK-OPT-NONX86 or CHECK-OPT-ARM for the check prefix?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87426/new/

https://reviews.llvm.org/D87426



More information about the cfe-commits mailing list