[PATCH] D87239: [analyzer][StdLibraryFunctionsChecker] Remove strcasecmp

Wed Sep 9 11:13:12 PDT 2020

steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

In D87239#2259428 <https://reviews.llvm.org/D87239#2259428>, @martong wrote:

> So, the problem is rather that the constraint check should be done in checkPreCall, but that should be in an NFC refactoring.

You are right, but we can not fix everything at once. There are quite a few changes under review related to the `CStringChecker` already.

In D87239#2263634 <https://reviews.llvm.org/D87239#2263634>, @martong wrote:

>> I completely agree with you.
>
> So, how should we proceed? :)

I'm fine with taking this reponsibilty out from the `StdLibraryFunctionsChecker`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87239/new/

https://reviews.llvm.org/D87239