[PATCH] D87374: [SyntaxTree] Specialize `TreeTestBase` for `BuildTreeTest` and `MutationsTest`

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 9 05:56:07 PDT 2020


eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/Syntax/MutationsTest.cpp:75-85
+INSTANTIATE_TEST_CASE_P(SyntaxTreeTests, SyntaxTreeTest,
+                        ::testing::ValuesIn(allTestClangConfigs()), );
+
 TEST_P(SyntaxTreeTest, SynthesizedNodes) {
   buildTree("", GetParam());
 
   auto *C = syntax::createPunctuation(*Arena, tok::comma);
----------------
I think it makes sense to split this into a separate file as well. 

If agreed this will be done in a separate patch, because it will also incur the creation of a `Synthesis.h`.

Currently `BuildTree.h` is backed by `Synthesis.cpp` and `BuildTree.cpp` which I don't think makes a lot of sense


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87374/new/

https://reviews.llvm.org/D87374



More information about the cfe-commits mailing list