[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Oh, there are a ton of typos in this documentation.



================
Comment at: clang/include/clang/Basic/AttrDocs.td:3396
+the imported API, and dynamically will always pass a valid address initialized
+to a null pointer.
+
----------------
Please split this sentence: "...API.  When calling the API, Swift will always pass a valid
address initialized to a null pointer."


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3404
+a pointer type, and it will be imported into Swift with a non-optional type.
+This is the dedfault error convention for Objective-C methods that return
+pointers.
----------------
Typo: "default"


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3409
+considered to have thrown if they return a zero result. The return type must be
+an integeral type. If the return type would have been imported as ``Bool``, it
+is instead imported as ``Void``. This is the default error convention for
----------------
Typo: "integral"


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3415
+considered to have thrown if they return a non-zero result. The return type must
+be an integeral type. If the return type would have been imported as ``Bool``,
+it is instead imported as ``Void``.
----------------
Typo: "integral"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87331/new/

https://reviews.llvm.org/D87331