[PATCH] D86699: [SyntaxTree] Ignore implicit non-leaf `CXXConstructExpr`
Eduardo Caldas via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 7 11:02:50 PDT 2020
eduucaldas added inline comments.
================
Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:4042
+
+TEST_P(SyntaxTreeTest, ExplicitConversion_ZeroArguments) {
+ if (!GetParam().isCXX()) {
----------------
gribozavr2 wrote:
> This is not a conversion, this is an explicit constructor call (CXXTemporaryObjectExpr) -- so please rename the test. Same for other tests below.
I am trying to follow the syntax to name things. And in the [[ https://eel.is/c++draft/expr.type.conv | grammar ]] this is under "Explicit type conversion (functional notation)", which englobes as well things of the type `float(3)`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86699/new/
https://reviews.llvm.org/D86699
More information about the cfe-commits
mailing list