[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

[Raul Tambre via Phabricator via cfe-commits]

tambre added a comment.

In D77491#2254967 <https://reviews.llvm.org/D77491#2254967>, @rjmccall wrote:

> I didn't see the specific example, sorry.  I agree that my description is more applicable to builtins in the `__builtin` namespace, which describes most of the builtins with custom typechecking.  Is the problem just `__va_start`?

I grepped for all builtins with custom typechecking.
I found two occurences in MSVC's headers: `__va_start` and `__GetExceptionInfo`, but none on my Debian Unstable machine.

> If we have to treat all declarations as builtins for the custom-typechecking builtins just to land this patch, I don't think that's the worst result in the world, and we can incrementally go from there.  `__va_start` actually has a signature, it just effectively has optional arguments, which is something we could definitely teach the builtins database and signature-matcher about.

I'd still prefer we go incrementally.

It would be nice to receive another round of code review after having fixed the issues pointed out by Richard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77491/new/

https://reviews.llvm.org/D77491