[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

Thu Sep 3 13:59:07 PDT 2020

snehasish added a comment.

Thanks for the comments! PTAL.

In D87047#2252982 <https://reviews.llvm.org/D87047#2252982>, @davidxl wrote:

> For x86 target, should it be turned on when -fprofile-use= option is specified unless -fno-split-machine-function is specified?

I don't think we are there yet to turn it on for x86 profile builds. There is at least one unresolved issue with DebugInfo (D85085 <https://reviews.llvm.org/D85085>); once we have tested this some more internally we can revisit and make it the default.

> Also is it worth to give a warning if the option is specified but PGO is not on?

Added a warning if no profile is specified but this option is turned on.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87047/new/

https://reviews.llvm.org/D87047