[PATCH] D87066: Thread safety analysis: Improve documentation for scoped capabilities

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 3 06:52:17 PDT 2020


aaron.ballman added inline comments.


================
Comment at: clang/docs/ThreadSafetyAnalysis.rst:922
+    // Releases *this and all underlying capabilities, if they are still held.
+    // There is no warning on double unlock.
     ~MutexLocker() RELEASE() {
----------------
This makes it sound like we're missing a diagnostic, but IIRC, this is intended behavior. Maybe we want to say there is purposefully no warning on double unlock and why? Or add a FIXME if I'm remembering wrong and this isn't intended behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87066/new/

https://reviews.llvm.org/D87066



More information about the cfe-commits mailing list