[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

[Mark de Wever via Phabricator via cfe-commits]

Mordante added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:244
 VALUE_CODEGENOPT(TimeTraceGranularity, 32, 500) ///< Minimum time granularity (in microseconds),
+CODEGENOPT(Perfetto          , 1, 0) ///< Set when -perfetto is enabled.
                                                ///< traced by time profiler
----------------
Seems this line should be one lower to keep the comment above together.


================
Comment at: clang/include/clang/Frontend/FrontendOptions.h:251
 
+  /// Output time trace profile.
+  unsigned Perfetto : 1;
----------------
Is it intended to have the same comment as `TimeTrace`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82994/new/

https://reviews.llvm.org/D82994