[PATCH] D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers

Balogh, Ádám via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 2 07:12:38 PDT 2020


baloghadamsoftware added a comment.

In D85351#2247095 <https://reviews.llvm.org/D85351#2247095>, @Szelethus wrote:

> I think its a bad experience if you break something while developing. Instead of getting a test failure for "delegating constructor initializers", you'll have to deal with a test that handles a variety of things at once, and are forced to tease it apart to find what just broke. When the introduced assert fires, this wouldn't be an issue, but in any non-crashing case it might be.

This is a crashing case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85351/new/

https://reviews.llvm.org/D85351



More information about the cfe-commits mailing list